Add createdTime field to SessionInformation
#17513
Open
+40
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therepanic
commented
Jul 13, 2025
Comment on lines
+136
to
+138
| Date currentDate = new Date(); | ||
| this.sessionIds.put(sessionId, new SessionInformation(principal, sessionId, new Date(currentDate.getTime()), | ||
| new Date(currentDate.getTime()))); |
There was a problem hiding this comment.
I think that's okay, since we wouldn't want to have a link to the same Date?
therepanic
commented
Jul 13, 2025
Comment on lines
+55
to
64
| public SessionInformation(Object principal, String sessionId, Date lastRequest, Date createdTime) { | ||
| Assert.notNull(principal, "Principal required"); | ||
| Assert.hasText(sessionId, "SessionId required"); | ||
| Assert.notNull(lastRequest, "LastRequest required"); | ||
| Assert.notNull(lastRequest, "CreatedTime required"); | ||
| this.principal = principal; | ||
| this.sessionId = sessionId; | ||
| this.lastRequest = lastRequest; | ||
| this.createdTime = createdTime; | ||
| } |
There was a problem hiding this comment.
I think that SessionInformation is created in SessionRegistry, so we don't need to maintain backward compatibility, right?
spring-projects-issues
added
the
status: waiting-for-triage
therepanic
force-pushed
the
gh-17359
branch
3 times, most recently
from
528743d to
7141e7a
Compare
Closes: spring-projectsgh-17359 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
commented
Jul 13, 2025
Comment on lines
48
to
55
| public OidcSessionInformation(String sessionId, Map<String, String> authorities, OidcUser user) { | ||
| super(user, sessionId, new Date()); | ||
| this(sessionId, authorities, user, new Date()); | ||
| } | ||
|
|
||
| private OidcSessionInformation(String sessionId, Map<String, String> authorities, OidcUser user, Date now) { | ||
| super(user, sessionId, new Date(now.getTime()), new Date(now.getTime())); | ||
| this.authorities = (authorities != null) ? new LinkedHashMap<>(authorities) : Collections.emptyMap(); | ||
| } |
There was a problem hiding this comment.
This is the only way to solve the problem I wrote about here #17513 (comment)
jgrandja
added
in: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: gh-17359